rgw: LDAP fix resource leak with wrong credentials

/src/rgw/ldap.h: moved ldap_unbind to outside of successful states to always clean up connections

Fixes: https://tracker.ceph.com/issues/57881
Signed-off-by: Johannes Liebl <68052021+jliebl-git@users.noreply.github.com>
Signed-off-by: Johannes <68052021+jliebl-git@users.noreply.github.com>
(cherry picked from commit fa8945e7a281e3cc3c42ce5313f2de3838dcfd41)

diff --git a/src/rgw/rgw_ldap.h b/src/rgw/rgw_ldap.h
index c37789acc591daeae834510a1ae70e274b9f7d7b..06986e5f59ac71ab87e18f46186a9fc2dc966663 100644 (file)
--- a/src/rgw/rgw_ldap.h
+++ b/src/rgw/rgw_ldap.h
@@ -83,10 +83,8 @@ namespace rgw {
                              (void*) &ldap_ver);
        if (ret == LDAP_SUCCESS) {
          ret = ldap_simple_bind_s(tldap, dn, pwd.c_str());
-         if (ret == LDAP_SUCCESS) {
-           (void) ldap_unbind(tldap);
-         }
        }
+       (void) ldap_unbind(tldap);
       }
       return ret; // OpenLDAP client error space
     }