]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/volumes: add missing `mgr` param
authorMichael Fritch <mfritch@suse.com>
Tue, 3 Mar 2020 15:21:30 +0000 (08:21 -0700)
committerMichael Fritch <mfritch@suse.com>
Thu, 5 Mar 2020 20:19:33 +0000 (13:19 -0700)
fixes mypy errors:

volumes/fs/operations/volume.py: note: In function "create_volume":
volumes/fs/operations/volume.py:216: error: Too few arguments for "remove_pool"
volumes/fs/operations/volume.py:223: error: Too few arguments for "remove_pool"
volumes/fs/operations/volume.py:224: error: Too few arguments for "remove_pool"

Fixes: https://tracker.ceph.com/issues/44393
Signed-off-by: Michael Fritch <mfritch@suse.com>
src/pybind/mgr/volumes/fs/operations/volume.py

index dc2984499a2f8f3c1282a52b6f140f87847f00bb..c1030d39fed18fb8cbe3d74a71c5f93462a658fd 100644 (file)
@@ -213,15 +213,15 @@ def create_volume(mgr, volname, placement):
     r, outb, outs = create_pool(mgr, data_pool)
     if r != 0:
         #cleanup
-        remove_pool(metadata_pool)
+        remove_pool(mgr, metadata_pool)
         return r, outb, outs
     # create filesystem
     r, outb, outs = create_filesystem(mgr, volname, metadata_pool, data_pool)
     if r != 0:
         log.error("Filesystem creation error: {0} {1} {2}".format(r, outb, outs))
         #cleanup
-        remove_pool(data_pool)
-        remove_pool(metadata_pool)
+        remove_pool(mgr, data_pool)
+        remove_pool(mgr, metadata_pool)
         return r, outb, outs
     # create mds
     return create_mds(mgr, volname, placement)