]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/rook: Add some more type annotations 32499/head
authorSebastian Wagner <sebastian.wagner@suse.com>
Mon, 6 Jan 2020 13:08:42 +0000 (14:08 +0100)
committerSebastian Wagner <sebastian.wagner@suse.com>
Tue, 7 Jan 2020 08:44:29 +0000 (09:44 +0100)
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
src/pybind/mgr/rook/module.py
src/pybind/mgr/rook/rook_cluster.py

index 38ead7c40d9a5bd69ae90c8ffd5463d0895c083d..73f53387b751fbebaeee1fa00a13b7e29206d85f 100644 (file)
@@ -304,14 +304,17 @@ class RookOrchestrator(MgrModule, orchestrator.Orchestrator):
         )
 
     def add_mds(self, spec):
+        # type: (orchestrator.StatelessServiceSpec) -> RookCompletion
         return self._service_add_decorate('MDS', spec,
                                        self.rook_cluster.add_filesystem)
 
     def add_rgw(self, spec):
+        # type: (orchestrator.RGWSpec) -> RookCompletion
         return self._service_add_decorate('RGW', spec,
                                        self.rook_cluster.add_objectstore)
 
     def add_nfs(self, spec):
+        # type: (orchestrator.NFSServiceSpec) -> RookCompletion
         return self._service_add_decorate("NFS", spec,
                                           self.rook_cluster.add_nfsgw)
 
@@ -349,6 +352,7 @@ class RookOrchestrator(MgrModule, orchestrator.Orchestrator):
         )
 
     def update_mds(self, spec):
+        # type: (orchestrator.StatelessServiceSpec) -> RookCompletion
         num = spec.count
         return write_completion(
             lambda: self.rook_cluster.update_mds_count(spec.name, num),
@@ -357,6 +361,7 @@ class RookOrchestrator(MgrModule, orchestrator.Orchestrator):
         )
 
     def update_nfs(self, spec):
+        # type: (orchestrator.NFSServiceSpec) -> RookCompletion
         num = spec.count
         return write_completion(
             lambda: self.rook_cluster.update_nfs_count(spec.name, num),
index 97fd2ddc4305846b1fe683be6705c7545e10beac..78475d23b31e2a198f0573bb14c5f663e7d1d54d 100644 (file)
@@ -336,6 +336,7 @@ class RookCluster(object):
                 raise
 
     def add_filesystem(self, spec):
+        # type: (orchestrator.StatelessServiceSpec) -> None
         # TODO use spec.placement
         # TODO warn if spec.extended has entries we don't kow how
         #      to action.