]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
radosgw-admin: fix infinite loop in 'datalog list' 35001/head
authorCasey Bodley <cbodley@redhat.com>
Tue, 24 Mar 2020 19:01:31 +0000 (15:01 -0400)
committerNathan Cutler <ncutler@suse.com>
Mon, 11 May 2020 16:27:22 +0000 (18:27 +0200)
affects datalog shards with more than 1000 entries

Fixes: https://tracker.ceph.com/issues/44751
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 166f38fe70e6afd2831bdb87a27c8fe757899b95)

Conflicts:
src/rgw/rgw_admin.cc
- nautilus has "log->list_entries" where master has
  "datalog_svc->list_entries"

src/rgw/rgw_admin.cc

index 550e649ef7522ba868f20cd56d334e3dc9befb2a..4ac204ddd242f2eb3839f141d46a6e560dd03daa 100644 (file)
@@ -7671,7 +7671,7 @@ next:
     do {
       list<rgw_data_change_log_entry> entries;
       if (specified_shard_id) {
-        ret = log->list_entries(shard_id, start_time.to_real_time(), end_time.to_real_time(), max_entries - count, entries, marker, NULL, &truncated);
+        ret = log->list_entries(shard_id, start_time.to_real_time(), end_time.to_real_time(), max_entries - count, entries, marker, &marker, &truncated);
       } else {
         ret = log->list_entries(start_time.to_real_time(), end_time.to_real_time(), max_entries - count, entries, log_marker, &truncated);
       }