]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd: tune the default for crimson_alien_op_num_threads. 39516/head
authorRadoslaw Zarzynski <rzarzyns@redhat.com>
Wed, 17 Feb 2021 12:04:37 +0000 (12:04 +0000)
committerRadoslaw Zarzynski <rzarzyns@redhat.com>
Wed, 17 Feb 2021 12:37:59 +0000 (12:37 +0000)
This commit tries to optimize the default size of AlienStore's
thread pool. Recent testing has shown the intial value, which
is `16`, is far from being optimal while the optimum is close
to `4`:

  https://gist.github.com/rzarzynski/c851212f4b0baef4097a6087533ba17b

Further testing by Mark Nelson suggests that the sweet spot is
closer to `8` taking into account 4 KB writes with lower queue
depths:

  https://docs.google.com/spreadsheets/d/1IR9ysWRkaGdX5e9w_YV8kfeeglR2pEY3V9hovY0ECV8/edit#gid=1884533182

As a kind of compromise `6` is proposed in this commit.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
src/common/options.cc

index 3412f92d994c51149edb1a468a52fa3782bd05ad..638574d4af3dec7d8f7c5474d628b25ae6675e40 100644 (file)
@@ -5579,7 +5579,7 @@ std::vector<Option> get_global_options() {
     .set_description("The maximum number concurrent IO operations, 0 for unlimited"),
 
     Option("crimson_alien_op_num_threads", Option::TYPE_UINT, Option::LEVEL_ADVANCED)
-    .set_default(16)
+    .set_default(6)
     .set_flag(Option::FLAG_STARTUP)
     .set_description("The number of threads for serving alienized ObjectStore"),