common: no need to include ceph_assert.h

src/common/convenience.h is a header-only library, and it does not use
dout or ceph_assert() utilities. so there is no need to include
`ceph_assert.h`.

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/src/common/convenience.h b/src/common/convenience.h
index ad01d48ba7d11b03572973d8ce73f7721000221a..db803c59d5a718053defeba651a300a827361945 100644 (file)
--- a/src/common/convenience.h
+++ b/src/common/convenience.h
@@ -21,10 +21,6 @@
 
 #include <boost/optional.hpp>
 
-#include "include/ceph_assert.h" // I despise you. Not you the reader, I'm talking
-                            // to the include file.
-
-
 #ifndef CEPH_COMMON_CONVENIENCE_H
 #define CEPH_COMMON_CONVENIENCE_H
 

diff --git a/src/test/common/CMakeLists.txt b/src/test/common/CMakeLists.txt
index f64960a05322b31db777e15b65063aa380fa77d6..c9c9177fa762a02089849cb9bc03bd7bd746650c 100644 (file)
--- a/src/test/common/CMakeLists.txt
+++ b/src/test/common/CMakeLists.txt
@@ -296,7 +296,6 @@ target_link_libraries(unittest_iso_8601 ceph-common)
 add_ceph_unittest(unittest_iso_8601)
 
 add_executable(unittest_convenience test_convenience.cc)
-target_link_libraries(unittest_convenience ceph-common)
 add_ceph_unittest(unittest_convenience)
 
 add_executable(unittest_bounded_key_counter