]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
os/bluestore: remove _reap_collection in umount.
authorJianpeng Ma <jianpeng.ma@intel.com>
Thu, 16 Nov 2017 14:11:07 +0000 (22:11 +0800)
committerJianpeng Ma <jianpeng.ma@intel.com>
Fri, 17 Nov 2017 10:14:59 +0000 (18:14 +0800)
Queue removed collections and reap removed collection in the same
thread(_kv_finalize_thread). If this thread terminated and mean all
removed collection handle. Unless expection, so add a assert.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
src/os/bluestore/BlueStore.cc

index 1a888d3b7c001686fea4ba4e8eaf13323051e2b8..cd4513be7c4ca4739e2eba7cf9152c08483dfa8b 100644 (file)
@@ -5522,7 +5522,6 @@ int BlueStore::umount()
     mempool_thread.shutdown();
     dout(20) << __func__ << " stopping kv thread" << dendl;
     _kv_stop();
-    _reap_collections();
     _flush_cache();
     dout(20) << __func__ << " closing" << dendl;
 
@@ -8479,6 +8478,7 @@ void BlueStore::_kv_stop()
   }
   kv_sync_thread.join();
   kv_finalize_thread.join();
+  assert(removed_collections.empty());
   {
     std::lock_guard<std::mutex> l(kv_lock);
     kv_stop = false;