]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
rbdmap: bugfix upstart script
authorStephan Renatus <s.renatus@x-ion.de>
Mon, 10 Mar 2014 14:17:41 +0000 (15:17 +0100)
committerSage Weil <sage@inktank.com>
Mon, 10 Mar 2014 15:54:37 +0000 (08:54 -0700)
It seems like the upstart script is lacking a little behind [the initscript](https://github.com/ceph/ceph/blob/master/src/init-rbdmap#L44-L49); however, this bugfix makes it actually do what it should do.

Before, the bug made the job just ignore all parameters, with the following error in /var/log/upstart/rbdmap.log:

```
rbd map volumes/volume-one
rbd: add failed: (22) Invalid argument
```

Signed-off-by: Stephan Renatus <s.renatus@x-ion.de>
Signed-off-by: Sage Weil <sage@inktank.com>
src/upstart/rbdmap.conf

index a581c2a3745e2388eb64ec9302690915fff6d763..eeefec3b2dc602b496874033238ab8391f6c17dd 100644 (file)
@@ -27,7 +27,7 @@ pre-start script
             DEV=rbd/$DEV
             ;;
         esac
-        for PARAM in $(echo $PARAM | tr ',' '\n'); do
+        for PARAM in $(echo $PARAMS | tr ',' '\n'); do
             CMDPARAMS="$CMDPARAMS --$(echo $PARAM | tr '=' ' ')"
         done
         if [ ! -b /dev/rbd/$DEV ]; then