common/bit_vector.hpp: do not move a temporary object

this change also silences a waring from clang:

src/common/bit_vector.hpp:278:21: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
      m_data.append(std::move(buffer::ptr(buffer_size - m_data.length())));
                    ^
../src/common/bit_vector.hpp:278:21: note: remove std::move call here
      m_data.append(std::move(buffer::ptr(buffer_size - m_data.length())));
                    ^~~~~~~~~~                                          ~

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/src/common/bit_vector.hpp b/src/common/bit_vector.hpp
index 0ffce1b295523d789f268ce0df14d513bd82358d..10ee6c3ed6ccda73c7feba999aaba6318517f239 100644 (file)
--- a/src/common/bit_vector.hpp
+++ b/src/common/bit_vector.hpp
@@ -275,7 +275,7 @@ void BitVector<_b>::resize(uint64_t size, bool zero) {
     if (zero) {
       m_data.append_zero(buffer_size - m_data.length());
     } else {
-      m_data.append(std::move(buffer::ptr(buffer_size - m_data.length())));
+      m_data.append(buffer::ptr(buffer_size - m_data.length()));
     }
   } else if (buffer_size < m_data.length()) {
     bufferlist bl;