rbd-mirror: fix strict weak ordering in PeerSpec::operator<

The mon_host tier branched on "mon_host < rhs.mon_host" but returned the
same comparison, so mon_host > rhs.mon_host fell through to key, both
a < b and b < a could hold.

Only Mirror::m_pool_replayers reaches operator< (via std::pair key).

Fixes: https://tracker.ceph.com/issues/78049
Signed-off-by: Sun Yuechi <sunyuechi@iscas.ac.cn>

diff --git a/src/tools/rbd_mirror/Types.h b/src/tools/rbd_mirror/Types.h
index ef13f20fa9c6cef4d61d6b70d2a345364ade2ecb..da83b62b37453faa4bea16ebcfce5f9c67bc37a7 100644 (file)
--- a/src/tools/rbd_mirror/Types.h
+++ b/src/tools/rbd_mirror/Types.h
@@ -156,7 +156,7 @@ struct PeerSpec {
       return cluster_name < rhs.cluster_name;
     } else if (client_name != rhs.client_name) {
       return client_name < rhs.client_name;
-    } else if (mon_host < rhs.mon_host) {
+    } else if (mon_host != rhs.mon_host) {
       return mon_host < rhs.mon_host;
     } else {
       return key < rhs.key;