ceph_objectstore_tool: On import following a split skip objects no longer in pg

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 68b27e25a3729566c3a22c0b71f70f7f3aca29a3)

Conflicts:
	src/tools/ceph_objectstore_tool.cc

diff --git a/src/tools/ceph_objectstore_tool.cc b/src/tools/ceph_objectstore_tool.cc
index 244fa3a55f628858a9d0ae7ee033763558514dfc..16eb1483515eeafe1c642a63a51f829f3701b145 100644 (file)
--- a/src/tools/ceph_objectstore_tool.cc
+++ b/src/tools/ceph_objectstore_tool.cc
@@ -1352,7 +1352,7 @@ int get_object_rados(librados::IoCtx &ioctx, bufferlist &bl)
   return 0;
 }
 
-int get_object(ObjectStore *store, coll_t coll, bufferlist &bl)
+int get_object(ObjectStore *store, coll_t coll, bufferlist &bl, OSDMap &curmap, coll_t final_coll)
 {
   ObjectStore::Transaction tran;
   ObjectStore::Transaction *t = &tran;
@@ -1367,6 +1367,34 @@ int get_object(ObjectStore *store, coll_t coll, bufferlist &bl)
   coll.is_pg_prefix(pg);
   SnapMapper mapper(&driver, 0, 0, 0, pg.shard);
 
+  assert(g_ceph_context);
+  if (ob.hoid.hobj.nspace != g_ceph_context->_conf->osd_hit_set_namespace) {
+    object_t oid = ob.hoid.hobj.oid;
+    object_locator_t loc(ob.hoid.hobj);
+    // XXX: Do we need to set the hash?
+    // loc.hash = ob.hoid.hash;
+    pg_t raw_pgid = curmap.object_locator_to_pg(oid, loc);
+    pg_t pgid = curmap.raw_pg_to_pg(raw_pgid);
+  
+    spg_t coll_pgid;
+    snapid_t coll_snap;
+    if (final_coll.is_pg(coll_pgid, coll_snap) == false) {
+      cerr << "INTERNAL ERROR: Bad collection during import" << std::endl;
+      return 1;
+    }
+    if (coll_pgid.shard != ob.hoid.shard_id) {
+      cerr << "INTERNAL ERROR: Importing shard " << coll_pgid.shard 
+        << " but object shard is " << ob.hoid.shard_id << std::endl;
+      return 1;
+    }
+     
+    if (coll_pgid.pgid != pgid) {
+      cerr << "Skipping object '" << ob.hoid << "' which no longer belongs in exported pg" << std::endl;
+      skip_object(bl);
+      return 0;
+    }
+  }
+
   t->touch(coll, ob.hoid);
 
   cout << "Write " << ob.hoid << std::endl;
@@ -1692,7 +1720,7 @@ int do_import(ObjectStore *store, OSDSuperblock& sb)
     }
     switch(type) {
     case TYPE_OBJECT_BEGIN:
-      ret = get_object(store, rmcoll, ebl);
+      ret = get_object(store, rmcoll, ebl, curmap, coll);
       if (ret) return ret;
       break;
     case TYPE_PG_METADATA:
@@ -1714,6 +1742,7 @@ int do_import(ObjectStore *store, OSDSuperblock& sb)
   }
 
   t = new ObjectStore::Transaction;
+  assert(ms.info.pgid == pgid);
   coll_t newcoll(ms.info.pgid);
   t->collection_rename(rmcoll, newcoll);