]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw: don't write to error repo for async notification failures
authorCasey Bodley <cbodley@redhat.com>
Tue, 31 Mar 2020 13:22:43 +0000 (09:22 -0400)
committerCasey Bodley <cbodley@redhat.com>
Mon, 13 Apr 2020 15:06:46 +0000 (11:06 -0400)
async notifications are just hints, and don't imply an obligation to
sync the bucket shard. if we fail to sync, don't write it to the error
repo for retry. we'll see the change later when processing the datalog

Signed-off-by: Casey Bodley <cbodley@redhat.com>
src/rgw/rgw_data_sync.cc

index 94ad515453612e6fe110b3e5b82117b37078fdf8..64c6710d9bf1c80cbcc33ce5e75e6f0f50230e60 100644 (file)
@@ -1658,7 +1658,7 @@ public:
         for (modified_iter = current_modified.begin(); modified_iter != current_modified.end(); ++modified_iter) {
           yield {
             tn->log(20, SSTR("received async update notification: " << *modified_iter));
-            spawn(new RGWDataSyncSingleEntryCR(sc, *modified_iter, string(), marker_tracker, error_repo, false, tn), false);
+            spawn(new RGWDataSyncSingleEntryCR(sc, *modified_iter, string(), marker_tracker, nullptr, false, tn), false);
           }
         }