]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/cephadm: add timeout when removing iscsi gateway.conf
authorAdam King <adking@redhat.com>
Wed, 5 May 2021 17:40:32 +0000 (13:40 -0400)
committerSage Weil <sage@newdream.net>
Fri, 7 May 2021 18:57:54 +0000 (13:57 -0500)
We already catch TimeoutExpired exceptions here but we don't
actually specify a timeout

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit ade46fda791ee2c2e1cac1c2376d56acf7ae4766)

src/pybind/mgr/cephadm/services/iscsi.py

index 7445acfcde97c8ee8a18dd3290315c5528f439a1..82b08a206c98f26530df7b4a46a8dd235b14acab 100644 (file)
@@ -187,7 +187,8 @@ class IscsiService(CephService):
                                 '-n', f'mgr.{self.mgr.get_mgr_id()}',
                                 '-p', cast(str, spec.pool),
                                 'rm',
-                                'gateway.conf'])
+                                'gateway.conf'],
+                               timeout=5)
                 logger.info(f'<gateway.conf> removed from {spec.pool}')
             except subprocess.CalledProcessError as ex:
                 logger.error(f'Error executing <<{ex.cmd}>>: {ex.output}')