]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
pybind/mgr/dashboard: move pytest into requirements.txt 48081/head
authorKefu Chai <kchai@redhat.com>
Thu, 1 Apr 2021 03:05:19 +0000 (11:05 +0800)
committerPrashant D <pdhange@redhat.com>
Wed, 14 Sep 2022 03:04:08 +0000 (23:04 -0400)
before this change, pytest is included by both requirements-lint.txt
and requirements-test.txt. this fails the install-deps.sh script when
collecting the python package wheels:

ERROR: Double requirement given: pytest<4 (from -r requirements-test.txt (line 2)) (already in pytest (from -r requirements-lint.txt (line 12)), name='pytest')

also, since pytest is unconditionally imported in the source, for instance,
in pybind/mgr/dashboard/tests/test_ceph_service.py

it would be more straightforward just to include it in requirements.txt.

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit eab195566d54122f826debd8efb7f36db78fa4e1)

Conflicts:
src/pybind/mgr/dashboard/requirements-lint.txt: Remove pytest==6.2.4 as pytest
                                                        moved to requirements.txt

src/pybind/mgr/dashboard/requirements-lint.txt
src/pybind/mgr/dashboard/requirements-test.txt
src/pybind/mgr/dashboard/requirements.txt

index be4c91a04dd73f4c868c7a1ea1d5f520008811b5..1b15f46817c2a695517217023ffa2d8d650489cf 100644 (file)
@@ -8,4 +8,3 @@ rstcheck==3.3.1
 autopep8==1.5.7
 pyfakefs==4.5.0
 isort==5.5.3
-pytest==6.2.4
index 8ff943566621d951c396933da9526ed645fa5871..625f5c358f1cb606e4cd377373c3557975acbbbd 100644 (file)
@@ -1,4 +1,3 @@
-pytest
 pytest-cov
 pytest-instafail
 pyfakefs==4.5.0
index fd5a2efaeed0c8dfa0959d97a53081f28896957d..84dee7efc9a2c723621704212caf13627fc0797a 100644 (file)
@@ -7,5 +7,6 @@ requests
 Routes
 -e ../../../python-common
 prettytable
+pytest
 pyyaml
 setuptools