]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
messages: Initializing uninitialized members MMonProbe 16815/head
authoramitkuma <amitkuma@redhat.com>
Fri, 4 Aug 2017 14:44:55 +0000 (20:14 +0530)
committeramitkuma <amitkuma@redhat.com>
Fri, 4 Aug 2017 14:44:55 +0000 (20:14 +0530)
Fixes coverity Issue:

** 717299 Uninitialized scalar field
2. uninit_member: Non-static class member op is not initialized in this constructor nor in any functions that it calls.
   4. uninit_member: Non-static class member paxos_first_version is not initialized in this constructor nor in any functions that it calls.
    6. uninit_member: Non-static class member paxos_last_version is not initialized in this constructor nor in any functions that it calls.
    8. uninit_member: Non-static class member has_ever_joined is not initialized in this constructor nor in any functions that it calls.

CID 717299 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
10. uninit_member: Non-static class member required_features is not initialized in this constructor nor in any functions that it calls

Signed-off-by: Amit Kumar amitkuma@redhat.com
src/messages/MMonProbe.h

index 91bf116b9dd5d0fff24b6fd32d9e93d76ee67615..c98fc3a759493528c9d489fb65958157deefb819 100644 (file)
@@ -47,14 +47,14 @@ public:
   }
   
   uuid_d fsid;
-  int32_t op;
+  int32_t op = 0;
   string name;
   set<int32_t> quorum;
   bufferlist monmap_bl;
-  version_t paxos_first_version;
-  version_t paxos_last_version;
-  bool has_ever_joined;
-  uint64_t required_features;
+  version_t paxos_first_version = 0;
+  version_t paxos_last_version = 0;
+  bool has_ever_joined = 0;
+  uint64_t required_features = 0;
 
   MMonProbe()
     : Message(MSG_MON_PROBE, HEAD_VERSION, COMPAT_VERSION) {}