]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
md/Sever.cc: fix straydn assert
authorSage Weil <sage@inktank.com>
Tue, 14 May 2013 17:31:27 +0000 (10:31 -0700)
committerSage Weil <sage@inktank.com>
Tue, 14 May 2013 17:31:27 +0000 (10:31 -0700)
From fb222a0a1c98a4141b6d0e79eac7a41c208f7147, we only know straydn is
non-null if oldin is non-null.

Signed-off-by: Sage Weil <sage@inktank.com>
src/mds/Server.cc

index 4afe10d693fd0cbba4eaba4d277f1d6e5dbfd8ed..b526b5e036ae8cd4de8e46db51bf49b5a4278011 100644 (file)
@@ -7103,9 +7103,10 @@ void Server::_rename_rollback_finish(Mutation *mut, MDRequest *mdr, CDentry *src
   if (destdn) {
     CInode *oldin = destdn->get_linkage()->get_inode();
     // update subtree map?
-    assert(straydn);
-    if (oldin && oldin->is_dir())
+    if (oldin && oldin->is_dir()) {
+      assert(straydn);
       mdcache->adjust_subtree_after_rename(oldin, straydn->get_dir(), true);
+    }
   }
 
   if (mds->is_resolve()) {