raise RuntimeError('unable to use device')
return uuid
+ # TODO: get rid of this method?
def get_lv(self, argument):
"""
Perform some parsing of the command-line value so that the process
vg_name, lv_name = argument.split('/')
except (ValueError, AttributeError):
return None
- return api.get_lv(lv_name=lv_name, vg_name=vg_name)
+ return api.get_first_lv(filters={'lv_name': lv_name, 'vg_name':
+ vg_name})
def setup_device(self, device_type, device_name, tags, size):
"""
Device examples: vg-name/lv-name, /dev/vg-name/lv-name
Requirements: Must be a logical volume (LV)
"""
- lv = api.get_lv(lv_name=device.lv_name, vg_name=device.vg_name)
+ lv = api.get_first_lv(filters={'lv_name': device.lv_name, 'vg_name':
+ device.vg_name})
self.unmount_lv(lv)
wipefs(device.abspath)
import pytest
+from ceph_volume.api import lvm as api
from ceph_volume.devices import lvm
from mock.mock import patch, Mock
@pytest.mark.parametrize('arg', ['', '///', None, '/dev/sda1'])
def test_no_journal_on_invalid_path(self, monkeypatch, arg):
- monkeypatch.setattr(lvm.prepare.api, 'get_lv', lambda **kw: False)
+ monkeypatch.setattr(api, '_get_lv', lambda **kw: False)
prepare = lvm.prepare.Prepare([])
assert prepare.get_lv(arg) is None
def test_no_journal_lv_found(self, monkeypatch):
# patch it with 0 so we know we are getting to get_lv
- monkeypatch.setattr(lvm.prepare.api, 'get_lv', lambda **kw: 0)
+ monkeypatch.setattr(api, '_get_lv', lambda **kw: 0)
prepare = lvm.prepare.Prepare([])
assert prepare.get_lv('vg/lv') == 0
# actually unused (not 100% sure) and can simply be removed
self.vg_name = vgs[0]
self._is_lvm_member = True
-
self.lvs.extend(lvm.get_device_lvs(path))
return self._is_lvm_member