rgw: flush datalog entries on shutdown

pending datalog entries need to be issued before shutdown. a race with
sshutdown is especially easy to reproduce with radosgw-admin, ie for
'bucket sync enable/disable'

Signed-off-by: Casey Bodley <cbodley@redhat.com>

diff --git a/src/rgw/rgw_bucket.cc b/src/rgw/rgw_bucket.cc
index 5f37624333330c367ebb10eb9de7407d30a78422..630c0aadf60affd92eec910ff14d008e87a2a42b 100644 (file)
--- a/src/rgw/rgw_bucket.cc
+++ b/src/rgw/rgw_bucket.cc
@@ -2398,7 +2398,7 @@ RGWDataChangesLog::~RGWDataChangesLog() {
 }
 
 void *RGWDataChangesLog::ChangesRenewThread::entry() {
-  do {
+  for (;;) {
     dout(2) << "RGWDataChangesLog::ChangesRenewThread: start" << dendl;
     int r = log->renew_entries();
     if (r < 0) {
@@ -2411,7 +2411,7 @@ void *RGWDataChangesLog::ChangesRenewThread::entry() {
     int interval = cct->_conf->rgw_data_log_window * 3 / 4;
     std::unique_lock locker{lock};
     cond.wait_for(locker, std::chrono::seconds(interval));
-  } while (!log->going_down());
+  }
 
   return NULL;
 }