]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
script/run-make.sh: quote targets with double quote 40236/head
authorKefu Chai <kchai@redhat.com>
Fri, 19 Mar 2021 11:23:09 +0000 (19:23 +0800)
committerKefu Chai <kchai@redhat.com>
Fri, 19 Mar 2021 11:25:25 +0000 (19:25 +0800)
in
ceph-build/ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml,
we pass "vstart-base crimson-osd" as the targets argument, but the
build() function in ceph/src/script/run-make.sh fails to quote them, so
they are expanded into two argument of `test -n`. hence it breaks like

src/script/run-make.sh: line 124: test: vstart-base: binary operator expected
make will run with option(s) -j40
Unknown argument vstart-base
Unknown argument crimson-osd

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/script/run-make.sh

index 7f50fafc9fa6f910c04bc3181c1f251e02ad3a14..9503b8b35bf58ff753b74735a21074be85877d30 100755 (executable)
@@ -121,7 +121,7 @@ function configure() {
 
 function build() {
     local targets="$@"
-    if test -n $targets; then
+    if test -n "$targets"; then
         targets="--target $targets"
     fi
     $DRY_RUN cd build