]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph-volume: add type annotations to devices.lvm.main
authorGuillaume Abrioux <gabrioux@ibm.com>
Wed, 8 Jan 2025 14:27:33 +0000 (14:27 +0000)
committerGuillaume Abrioux <gabrioux@ibm.com>
Mon, 20 Jan 2025 07:48:10 +0000 (07:48 +0000)
This commit adds the Python type annotations to `devices.lvm.main`.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
src/ceph-volume/ceph_volume/devices/lvm/main.py

index 39947454d57f57b28e8e4225363d8213c010b32f..7f8c40361a0f316915ac5ae51d9a0f2cc31f25a6 100644 (file)
@@ -10,9 +10,10 @@ from . import listing
 from . import zap
 from . import batch
 from . import migrate
+from typing import List, Optional
 
 
-class LVM(object):
+class LVM:
 
     help = 'Use LVM and LVM-based technologies to deploy OSDs'
 
@@ -36,19 +37,21 @@ class LVM(object):
         'new-db': migrate.NewDB,
     }
 
-    def __init__(self, argv):
+    def __init__(self, argv: Optional[List[str]]) -> None:
         self.argv = argv
 
-    def print_help(self, sub_help):
+    def print_help(self, sub_help: str) -> str:
         return self._help.format(sub_help=sub_help)
 
-    def main(self):
+    def main(self) -> None:
         terminal.dispatch(self.mapper, self.argv)
         parser = argparse.ArgumentParser(
             prog='ceph-volume lvm',
             formatter_class=argparse.RawDescriptionHelpFormatter,
             description=self.print_help(terminal.subhelp(self.mapper)),
         )
+        if self.argv is None:
+            self.argv = []
         parser.parse_args(self.argv)
         if len(self.argv) <= 1:
-            return parser.print_help()
+            parser.print_help()