]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw: rgw_admin use raii for curl init/teardown 20749/head
authorAbhishek Lekshmanan <abhishek@suse.com>
Mon, 5 Mar 2018 16:59:33 +0000 (17:59 +0100)
committerAbhishek Lekshmanan <abhishek@suse.com>
Tue, 6 Mar 2018 14:32:48 +0000 (15:32 +0100)
Since a lot of rgw-admin commands can exit early

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 4667937e4cece63751d5406d75c140418910a823)

src/rgw/rgw_admin.cc

index 7ae2e1e8244712cd7d6005152f19dfa92c827940..3f32320549b4aa760ced8372464cf89283f11540 100644 (file)
@@ -2745,7 +2745,15 @@ int main(int argc, char **argv)
 
   rgw_user_init(store);
   rgw_bucket_init(store->meta_mgr);
-  rgw::curl::setup_curl(boost::none);
+
+  struct rgw_curl_setup {
+    rgw_curl_setup() {
+      rgw::curl::setup_curl(boost::none);
+    }
+    ~rgw_curl_setup() {
+      rgw::curl::cleanup_curl();
+    }
+  } curl_cleanup;
 
   StoreDestructor store_destructor(store);
 
@@ -6404,6 +6412,5 @@ next:
     }
   }
 
-  rgw::curl::cleanup_curl();
   return 0;
 }