]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph-volume: address mypy errors in disk.py
authorGuillaume Abrioux <gabrioux@ibm.com>
Wed, 9 Oct 2024 15:00:53 +0000 (15:00 +0000)
committerGuillaume Abrioux <gabrioux@ibm.com>
Wed, 16 Oct 2024 13:42:10 +0000 (13:42 +0000)
typical error:

```
ceph_volume/util/disk.py:1374: error: Incompatible types in assignment (expression has type "Optional[str]", variable has type "str")  [assignment]
```

This commits addresses it.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
src/ceph-volume/ceph_volume/util/disk.py

index 78c140597d653ac1a96715038e3d20381a6d7870..3ac51c11e3469b2744f999a9bd85f2312223098f 100644 (file)
@@ -1370,8 +1370,8 @@ class UdevData:
         """
         result: str = self.path
         if self.is_lvm:
-            vg: str = self.environment.get('DM_VG_NAME')
-            lv: str = self.environment.get('DM_LV_NAME')
+            vg: str = self.environment.get('DM_VG_NAME', '')
+            lv: str = self.environment.get('DM_LV_NAME', '')
             result = f'/dev/{vg}/{lv}'
         return result
 
@@ -1385,6 +1385,6 @@ class UdevData:
         """
         result: str = self.path
         if self.is_lvm:
-            name: str = self.environment.get('DM_NAME')
+            name: str = self.environment.get('DM_NAME', '')
             result = f'/dev/mapper/{name}'
         return result