objectcacher: delete unused onfinish from flush_set

Once upon a time the caller would do this, but none of those have survived,
and this makes more sense.

Signed-off-by: Sage Weil <sage.weil@dreamhost.com>

diff --git a/src/osdc/ObjectCacher.cc b/src/osdc/ObjectCacher.cc
index 1b20fbe7200372146f080bbe82516177168c82da..41ed4dd712d982d0b510c44661cb8d3a2ba6b6a5 100644 (file)
--- a/src/osdc/ObjectCacher.cc
+++ b/src/osdc/ObjectCacher.cc
@@ -1427,6 +1427,7 @@ bool ObjectCacher::flush_set(ObjectSet *oset, Context *onfinish)
 {
   if (oset->objects.empty()) {
     ldout(cct, 10) << "flush_set on " << oset << " dne" << dendl;
+    delete onfinish;
     return true;
   }
 
@@ -1457,6 +1458,7 @@ bool ObjectCacher::flush_set(ObjectSet *oset, Context *onfinish)
   
   if (safe) {
     ldout(cct, 10) << "flush_set " << oset << " has no dirty|tx bhs" << dendl;
+    delete onfinish;
     return true;
   }
   return false;
@@ -1468,6 +1470,7 @@ bool ObjectCacher::flush_set(ObjectSet *oset, vector<ObjectExtent>& exv, Context
 {
   if (oset->objects.empty()) {
     ldout(cct, 10) << "flush_set on " << oset << " dne" << dendl;
+    delete onfinish;
     return true;
   }
 
@@ -1503,6 +1506,7 @@ bool ObjectCacher::flush_set(ObjectSet *oset, vector<ObjectExtent>& exv, Context
   
   if (safe) {
     ldout(cct, 10) << "flush_set " << oset << " has no dirty|tx bhs" << dendl;
+    delete onfinish;
     return true;
   }
   return false;