]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw: make rollback refcount tag match 30891/head
authorJ. Eric Ivancich <ivancich@redhat.com>
Thu, 29 Aug 2019 14:41:53 +0000 (10:41 -0400)
committerNathan Cutler <ncutler@suse.com>
Mon, 14 Oct 2019 11:37:08 +0000 (13:37 +0200)
When the refcount does a "get", the tag ends with a null character,
but during a rollback, when the tag is "put" it does not end with a
null character, so the same tag is not being manipulated and the
refcounts are therefore off, preventing future deletion of an rgw
object. This adds the null character to the "put" operation.

This change was originally submitted by lltlo <120680451@qq.com> but
wasn't signed-off.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit a0fee94982d89f0210e1c526605831105cd90ef4)

Conflicts:
src/rgw/rgw_rados.cc

src/rgw/rgw_rados.cc

index 402715d9b45c681cd6adb0e1ad4ae4307c18cfc3..a806be7690cb3467078938f59512bdacc450233d 100644 (file)
@@ -8591,9 +8591,10 @@ done_ret:
     vector<rgw_raw_obj>::iterator riter;
 
     /* rollback reference */
+    string ref_tag = tag + '\0';
     for (riter = ref_objs.begin(); riter != ref_objs.end(); ++riter) {
       ObjectWriteOperation op;
-      cls_refcount_put(op, tag, true);
+      cls_refcount_put(op, ref_tag, true);
 
       ref.ioctx.locator_set_key(riter->loc);