]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/telemetry: fix issue with incompatible types 42569/head
authorLaura Flores <lflores@redhat.com>
Tue, 10 Aug 2021 21:55:45 +0000 (21:55 +0000)
committerLaura Flores <lflores@redhat.com>
Tue, 10 Aug 2021 21:55:45 +0000 (21:55 +0000)
Signed-off-by: Laura Flores <lflores@redhat.com>
src/pybind/mgr/telemetry/module.py

index 4d6433e8c41ccc97b4e551dfa3c0621d59bd1b5f..91596436a9d86adcef2dd4f5bf9b8201d800a4ea 100644 (file)
@@ -354,7 +354,7 @@ class Module(MgrModule):
 
         return result
 
-    def get_osd_histograms(self) -> Dict[str, dict]:
+    def get_osd_histograms(self) -> List[Dict[str, dict]]:
         # Initialize result dict
         result: Dict[str, dict] = defaultdict(lambda: defaultdict(
                                               lambda: defaultdict(
@@ -455,7 +455,7 @@ class Module(MgrModule):
                 # by returning an empty dict.
                 except (json.decoder.JSONDecodeError, KeyError) as e:
                     self.log.debug("Error caught: {}".format(e))
-                    return {}
+                    return list()
 
         return list(result.values())