]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
Merge pull request #44751 from rhcs-dashboard/introduce-logging-containers
authorErnesto Puerta <37327689+epuertat@users.noreply.github.com>
Wed, 16 Mar 2022 13:06:55 +0000 (14:06 +0100)
committerGitHub <noreply@github.com>
Wed, 16 Mar 2022 13:06:55 +0000 (14:06 +0100)
mgr/cephadm: introduce centralized logging in Dashboard using Loki and Promtail

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: rkachach <NOT@FOUND>
Reviewed-by: sunilangadi2 <NOT@FOUND>
Reviewed-by: umangachapagain <NOT@FOUND>
1  2 
src/cephadm/cephadm
src/pybind/mgr/cephadm/module.py
src/pybind/mgr/cephadm/tests/test_services.py
src/pybind/mgr/orchestrator/_interface.py
src/pybind/mgr/orchestrator/module.py
src/python-common/ceph/deployment/service_spec.py

Simple merge
Simple merge
Simple merge
index 11c05f0600997d75f3339b5606497b422087d299,baeb7e7ff1cf586869a92374790f40cdcae23673..e7b6885ab1e5a7d6a204752d05eb7e91d706701b
@@@ -1067,9 -1055,9 +1069,10 @@@ class MonitoringSpec(ServiceSpec)
                   unmanaged: bool = False,
                   preview_only: bool = False,
                   port: Optional[int] = None,
 +                 extra_container_args: Optional[List[str]] = None,
                   ):
-         assert service_type in ['grafana', 'node-exporter', 'prometheus', 'alertmanager']
+         assert service_type in ['grafana', 'node-exporter', 'prometheus', 'alertmanager',
+                                 'loki', 'promtail']
  
          super(MonitoringSpec, self).__init__(
              service_type, service_id,