rgw: use const reference to avoid copy

Signed-off-by: Orit Wasserman <owasserm@redhat.com>

diff --git a/src/rgw/rgw_rados.cc b/src/rgw/rgw_rados.cc
index cb900149875d18049050be5594a2c1d1be717b51..3efcea47643cf0c1731426bcf756f1768c9a3503 100644 (file)
--- a/src/rgw/rgw_rados.cc
+++ b/src/rgw/rgw_rados.cc
@@ -12443,7 +12443,7 @@ int RGWRados::cls_user_sync_bucket_stats(rgw_raw_obj& user_obj, const RGWBucketI
 
   bucket_info.bucket.convert(&entry.bucket);
 
-  for (auto hiter : headers) {
+  for (const auto& hiter : headers) {
     for (const auto& iter : hiter.second.stats) {
       const struct rgw_bucket_category_stats& header_stats = iter.second;
       entry.size += header_stats.total_size;
@@ -12464,7 +12464,7 @@ int RGWRados::cls_user_sync_bucket_stats(rgw_raw_obj& user_obj, const RGWBucketI
   return 0;
 }
 
-int RGWRados::cls_user_get_bucket_stats(rgw_bucket& bucket, cls_user_bucket_entry& entry)
+int RGWRados::cls_user_get_bucket_stats(const rgw_bucket& bucket, cls_user_bucket_entry& entry)
 {
   map<string, struct rgw_bucket_dir_header> headers;
   RGWBucketInfo bucket_info;

diff --git a/src/rgw/rgw_rados.h b/src/rgw/rgw_rados.h
index ae20213439efdcdb418812078ead892fac70bd4e..6da500262e54df6dc1dd6e953fa3314ba2bc1c2e 100644 (file)
--- a/src/rgw/rgw_rados.h
+++ b/src/rgw/rgw_rados.h
@@ -3430,7 +3430,7 @@ public:
   int complete_sync_user_stats(const rgw_user& user_id);
   int cls_user_add_bucket(rgw_raw_obj& obj, list<cls_user_bucket_entry>& entries);
   int cls_user_remove_bucket(rgw_raw_obj& obj, const cls_user_bucket& bucket);
-  int cls_user_get_bucket_stats(rgw_bucket& bucket, cls_user_bucket_entry& entry);
+  int cls_user_get_bucket_stats(const rgw_bucket& bucket, cls_user_bucket_entry& entry);
 
   int check_quota(const rgw_user& bucket_owner, rgw_bucket& bucket,
                   RGWQuotaInfo& user_quota, RGWQuotaInfo& bucket_quota, uint64_t obj_size);

diff --git a/src/rgw/rgw_user.cc b/src/rgw/rgw_user.cc
index 4d68758ceae7cf47429713f5357cdf23fe6e136b..34ac237934ed5f4343e14f24849a8a1436d5fe69 100644 (file)
--- a/src/rgw/rgw_user.cc
+++ b/src/rgw/rgw_user.cc
@@ -107,10 +107,10 @@ int rgw_user_get_all_buckets_stats(RGWRados *store, const rgw_user& user_id, map
       return ret;
     }
     map<string, RGWBucketEnt>& buckets = user_buckets.get_buckets();
-    for (auto i :  buckets) {
+    for (const auto& i :  buckets) {
       marker = i.first;
 
-      RGWBucketEnt& bucket_ent = i.second;
+      const RGWBucketEnt& bucket_ent = i.second;
       cls_user_bucket_entry entry;
       ret = store->cls_user_get_bucket_stats(bucket_ent.bucket, entry);
       if (ret < 0) {