]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/os/seastore/cache: root may not be loaded in duplicate_for_write
authorSamuel Just <sjust@redhat.com>
Thu, 18 Mar 2021 05:44:12 +0000 (22:44 -0700)
committerSamuel Just <sjust@redhat.com>
Wed, 24 Mar 2021 05:41:11 +0000 (22:41 -0700)
In particular, SegmentCleaner::rewite_dirty may operate on root as the
first operation.

Signed-off-by: Samuel Just <sjust@redhat.com>
src/crimson/os/seastore/cache.cc

index 57d5bf5406ea2728e08892402c31701ed9e1ce5b..e976d9bb6604e0e44d7f699ff3c4c1ef1c37aaa0 100644 (file)
@@ -177,8 +177,6 @@ CachedExtentRef Cache::duplicate_for_write(
   ret->prior_instance = i;
   t.add_mutated_extent(ret);
   if (ret->get_type() == extent_types_t::ROOT) {
-    // root must be loaded before mutate
-    assert(t.root == i);
     t.root = ret->cast<RootBlock>();
   } else {
     ret->last_committed_crc = i->last_committed_crc;