]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
pybind/rbd: explain why "primary" isn't exposed in mirror_image_status_list() 42971/head
authorIlya Dryomov <idryomov@gmail.com>
Tue, 27 Jul 2021 16:45:20 +0000 (18:45 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 30 Aug 2021 12:18:20 +0000 (14:18 +0200)
"primary" is part of mirror image info (rbd_mirror_image_info_t) and
is exposed in mirror_image_get_status().  mirror_image_status_list(),
even though it is often thought of as an equivalent of repeated calls
to mirror_image_get_status(), doesn't actually fetch the mirror image
info.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 1d2a142108b2aa102103e62ccdf3bd17688b783b)

src/pybind/rbd/rbd.pyx

index de2b5d3c3fa1b0c80b39679a5407c7fa877de3a5..b0206cd16be2a3389de65df543114bb05a56046f 100644 (file)
@@ -2876,6 +2876,8 @@ cdef class MirrorImageStatusIterator(object):
                     'info'        : {
                         'global_id' : decode_cstr(self.images[i].info.global_id),
                         'state'     : self.images[i].info.state,
+                        # primary isn't added here because it is unknown (always
+                        # false, see XXX in Mirror::image_global_status_list())
                         },
                     'remote_statuses': site_statuses,
                     }