]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
doc: clarify crush rule create-simple and fix typos
authorLoic Dachary <loic@dachary.org>
Thu, 21 Nov 2013 12:08:19 +0000 (13:08 +0100)
committerJosh Durgin <josh.durgin@inktank.com>
Tue, 26 Nov 2013 17:44:49 +0000 (09:44 -0800)
update the description of osd crush rule create-simple using terms that
match the keywords from the crushmap to avoid confusion.

fix missing closing parenthesis in osd crush commands

Signed-off-by: Loic Dachary <loic@dachary.org>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
src/mon/MonCommands.h

index 5a6ca6a471d265dcaba4ca5f621c8990e37f2fe8..e3f347606f72d2580cf0d8d01cf144ab50e798da 100644 (file)
@@ -405,17 +405,17 @@ COMMAND("osd crush link " \
 COMMAND("osd crush rm " \
        "name=name,type=CephString,goodchars=[A-Za-z0-9-_.] " \
        "name=ancestor,type=CephString,req=false,goodchars=[A-Za-z0-9-_.]", \
-       "remove <name> from crush map (everywhere, or just at <ancestor>",\
+       "remove <name> from crush map (everywhere, or just at <ancestor>)",\
        "osd", "rw", "cli,rest")
 COMMAND("osd crush remove " \
        "name=name,type=CephString,goodchars=[A-Za-z0-9-_.] " \
        "name=ancestor,type=CephString,req=false,goodchars=[A-Za-z0-9-_.]", \
-       "remove <name> from crush map (everywhere, or just at <ancestor>", \
+       "remove <name> from crush map (everywhere, or just at <ancestor>)", \
        "osd", "rw", "cli,rest")
 COMMAND("osd crush unlink " \
        "name=name,type=CephString,goodchars=[A-Za-z0-9-_.] " \
        "name=ancestor,type=CephString,req=false,goodchars=[A-Za-z0-9-_.]", \
-       "unlink <name> from crush map (everywhere, or just at <ancestor>", \
+       "unlink <name> from crush map (everywhere, or just at <ancestor>)", \
        "osd", "rw", "cli,rest")
 COMMAND("osd crush reweight " \
        "name=name,type=CephString,goodchars=[A-Za-z0-9-_.] " \
@@ -429,7 +429,7 @@ COMMAND("osd crush rule create-simple " \
        "name=name,type=CephString,goodchars=[A-Za-z0-9-_.] " \
        "name=root,type=CephString,goodchars=[A-Za-z0-9-_.] " \
        "name=type,type=CephString,goodchars=[A-Za-z0-9-_.]",
-       "create crush rule <name> in <root> of type <type>", \
+       "create crush rule <name> to 'take' from bucket <root> and 'chooseleaf_first' a bucket <type>", \
        "osd", "rw", "cli,rest")
 COMMAND("osd crush rule rm " \
        "name=name,type=CephString,goodchars=[A-Za-z0-9-_.] ",  \