mon: Monitor: fix bug on _pick_random_mon() that would choose an invalid rank

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>

diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc
index 54e722ac948c67503936737ce41df12bb613ad96..b9afa4265d8fc7397cea662c4c3a9883b86371c2 100644 (file)
--- a/src/mon/Monitor.cc
+++ b/src/mon/Monitor.cc
@@ -1071,6 +1071,8 @@ int Monitor::_pick_random_mon(int other)
     return 0;
 
   int max = monmap->size();
+  if (other >= 0)
+    max--;
   int n = sync_rng() % max;
   if (other >= 0 && n >= other)
     n++;