]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
safe_io: Improve portability by replacing loff_t type usage with off_t. 9767/head
authorJohn Coyle <dx9err@gmail.com>
Tue, 8 Mar 2016 19:04:43 +0000 (14:04 -0500)
committerJohn Coyle <dx9err@gmail.com>
Thu, 23 Jun 2016 14:08:29 +0000 (10:08 -0400)
64-bit behavior on glibc is enforced with __USE_FILE_OFFSET64 compiler error.

Signed-off-by: John Coyle <dx9err@gmail.com>
src/common/safe_io.c
src/common/safe_io.h

index 9367a9abb969fbdce0514cc30ec69be45a5cf357..a4a31aaba9ad108d996eb8c5819aa24c5c2c7e25 100644 (file)
@@ -119,7 +119,7 @@ ssize_t safe_pwrite(int fd, const void *buf, size_t count, off_t offset)
 }
 
 #ifdef CEPH_HAVE_SPLICE
-ssize_t safe_splice(int fd_in, loff_t *off_in, int fd_out, loff_t *off_out,
+ssize_t safe_splice(int fd_in, off_t *off_in, int fd_out, off_t *off_out,
                    size_t len, unsigned int flags)
 {
   size_t cnt = 0;
@@ -142,8 +142,8 @@ ssize_t safe_splice(int fd_in, loff_t *off_in, int fd_out, loff_t *off_out,
   return cnt;
 }
 
-ssize_t safe_splice_exact(int fd_in, loff_t *off_in, int fd_out,
-                         loff_t *off_out, size_t len, unsigned int flags)
+ssize_t safe_splice_exact(int fd_in, off_t *off_in, int fd_out,
+                         off_t *off_out, size_t len, unsigned int flags)
 {
   ssize_t ret = safe_splice(fd_in, off_in, fd_out, off_out, len, flags);
   if (ret < 0)
index c45589eee7e05670e047ac5524e3c91ad64f5621..9ba34b6bcd3d6c4b975032b0186fef7dce875b22 100644 (file)
@@ -41,11 +41,11 @@ extern "C" {
    * Similar to the above (non-exact version) and below (exact version).
    * See splice(2) for parameter descriptions.
    */
-  ssize_t safe_splice(int fd_in, loff_t *off_in, int fd_out, loff_t *off_out,
+  ssize_t safe_splice(int fd_in, off_t *off_in, int fd_out, off_t *off_out,
                      size_t len, unsigned int flags)
     WARN_UNUSED_RESULT;
-  ssize_t safe_splice_exact(int fd_in, loff_t *off_in, int fd_out,
-                           loff_t *off_out, size_t len, unsigned int flags)
+  ssize_t safe_splice_exact(int fd_in, off_t *off_in, int fd_out,
+                           off_t *off_out, size_t len, unsigned int flags)
     WARN_UNUSED_RESULT;
 #endif