]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/common/errorator: add TODO
authorMatan Breizman <mbreizma@redhat.com>
Thu, 10 Apr 2025 13:12:36 +0000 (13:12 +0000)
committerMatan Breizman <mbreizma@redhat.com>
Tue, 22 Apr 2025 15:11:58 +0000 (15:11 +0000)
There are few TODOs around errorator code which might be worth looking
into: https://tracker.ceph.com/issues/70875

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
src/crimson/common/errorator.h

index b13afd83340760466da331df85396ecc0fe38c23..75bce8d663d6b9266a3d5e1d8cd30700c2bafbc7 100644 (file)
@@ -409,6 +409,8 @@ public:
       // However, this shouldn't be a big issue for `errorator` as
       // ErrorVisitorT are already checked for exhaustiveness at compile-time.
       if (type_info == ErrorT::error_t::get_exception_ptr_type_info()) {
+
+        // TODO: add missing explanation
         if constexpr (std::is_assignable_v<decltype(result), return_t>) {
           result = std::invoke(std::forward<ErrorVisitorT>(errfunc),
                                ErrorT::error_t::from_exception_ptr(std::move(ep)));