]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
pybind/mgr/tox.ini: add commas in "modules" variable 49542/head
authorKefu Chai <tchaikov@gmail.com>
Sun, 18 Dec 2022 12:18:44 +0000 (20:18 +0800)
committerPedro Gonzalez Gomez <pegonzal@redhat.com>
Thu, 22 Dec 2022 12:19:48 +0000 (13:19 +0100)
since tox v4.0.13, it parses the variables differently, so the newlines
in a variable are passed right to the command referencing it. so we now
have failure like:
```
flake8: commands[0] /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr> flake8 --config=tox.ini alerts
flake8: commands[1] /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr> balancer
flake8: exit 2 (0.00 seconds) /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr> balancer
flake8: FAIL ✖ in 3.33 seconds
```
so we have to add comma as line continuation separator to address
this problem.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 0cc649f029d40555e1d059e3de3739be7b9ae197)

 Conflicts:
src/pybind/mgr/tox.ini

pacific has different modules in flake8's tox file which conflicted with the main branch.

src/pybind/mgr/tox.ini

index d70927b0d6e4beee81e1688d935567f431e5b608..c97992113d542156424e41adee0737e631c6c18a 100644 (file)
@@ -122,10 +122,10 @@ deps =
     flake8
 allowlist_externals = bash
 modules =
-    cephadm
-    cli_api
-    nfs
-    orchestrator
+    cephadm \
+    cli_api \
+    nfs \
+    orchestrator \
     prometheus
 commands =
     flake8 --config=tox.ini {posargs} \