]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw_rados: sanitize dout print in GWRados::get_obj_iterate_cb(...) 12767/head
authorMatt Benjamin <mbenjamin@redhat.com>
Fri, 6 Jan 2017 20:16:32 +0000 (15:16 -0500)
committerMatt Benjamin <mbenjamin@redhat.com>
Sat, 7 Jan 2017 23:34:47 +0000 (18:34 -0500)
We cannot assume pbl may be deferenced.  Per review, move the dout
print into the r < 0 condition--since it's now an error, make it's
trace level 0.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
src/rgw/rgw_rados.cc

index 13afc5bc4454cea59b6e8db82025166a5d1e6e33..8757baf1c57864a34744a161cb9b38949fc3e614 100644 (file)
@@ -1,4 +1,3 @@
-
 // -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*-
 // vim: ts=8 sw=2 smarttab
 
@@ -9908,9 +9907,10 @@ int RGWRados::get_obj_iterate_cb(RGWObjectCtx *ctx, RGWObjState *astate,
   io_ctx.locator_set_key(key);
 
   r = io_ctx.aio_operate(oid, c, &op, NULL);
-  ldout(cct, 20) << "rados->aio_operate r=" << r << " bl.length=" << pbl->length() << dendl;
-  if (r < 0)
-    goto done_err;
+  if (r < 0) {
+       ldout(cct, 0) << "rados->aio_operate r=" << r << dendl;
+       goto done_err;
+  }
 
   // Flush data to client if there is any
   r = flush_read_list(d);