]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
Partial revert "mon: osd pool set syntax relaxed, modify unit tests"
authorSage Weil <sage@inktank.com>
Mon, 2 Dec 2013 06:21:31 +0000 (22:21 -0800)
committerGreg Farnum <greg@inktank.com>
Wed, 11 Dec 2013 23:33:18 +0000 (15:33 -0800)
This reverts commit 08327fed8213a5d24cd642e12b38a171b98924cb, except
for the hashpspool bit.  We switched back to an integer argument in
commit 337195f04653eed8e8f153a5b074f3bd48408998.

Signed-off-by: Sage Weil <sage@inktank.com>
(cherry picked from commit e80ab94bf44e102fcd87d16dc11e38ca4c0eeadb)
Reviewed-by: Greg Farnum <greg@inktank.com>
src/test/pybind/test_ceph_argparse.py

index 540f690472b028e50ab007aeb76c9188e0a725f2..f8e3f49fb3380253d8a2917acb2d5af92b8d602a 100755 (executable)
@@ -946,14 +946,20 @@ class TestOSD(TestArgparse):
                     'pg_num', 'pgp_num', 'crush_ruleset',
                                        'hashpspool'):
             self.assert_valid_command(['osd', 'pool',
-                                       'set', 'poolname', var, 'value'])
+                                       'set', 'poolname', var, '-1'])
         assert_equal({}, validate_command(sigdict, ['osd', 'pool',
                                                     'set']))
         assert_equal({}, validate_command(sigdict, ['osd', 'pool',
                                                     'set', 'poolname']))
         assert_equal({}, validate_command(sigdict, ['osd', 'pool',
                                                     'set', 'poolname',
-                                                    'size', 'value',
+                                                    'size', 'invalid']))
+        assert_equal({}, validate_command(sigdict, ['osd', 'pool',
+                                                    'set', 'poolname',
+                                                    'invalid', '-1']))
+        assert_equal({}, validate_command(sigdict, ['osd', 'pool',
+                                                    'set', 'poolname',
+                                                    'size', '-1',
                                                     'toomany']))
 
     def test_pool_set_quota(self):