]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/dashboard: show checkboxes for booleans 33388/head
authorTatjana Dehler <tdehler@suse.com>
Fri, 24 Jan 2020 16:02:22 +0000 (17:02 +0100)
committerTatjana Dehler <tdehler@suse.com>
Tue, 18 Feb 2020 14:48:01 +0000 (15:48 +0100)
The frontend showed textboxes for the dashboard settings because
the actual type information was missing here. The REST API then
returned the default type 'str'.

Edit the e2e test case in order to update a different setting as
the 'editMgrModule' method can't handle checkboxes.

Fixes: https://tracker.ceph.com/issues/43769
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit 7e7cac98116e76bc9e4c52ac47796e3fcd880667)

src/pybind/mgr/dashboard/settings.py

index bda0dda04133d29a2e31cd91eaefa02578d72e59..31e09fac5ed215d2a66b8d37131d173126809711 100644 (file)
@@ -153,7 +153,8 @@ def options_schema_list():
     for option, value in inspect.getmembers(Options, filter_attr):
         if option.startswith('_'):
             continue
-        result.append({'name': option, 'default': value[0]})
+        result.append({'name': option, 'default': value[0],
+                       'type': value[1].__name__})
 
     return result