radosgw-admin: don't always generate access key for subusers

Only generate key for subuser if one was not specified for it, and only
when creating a subuser.

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>

diff --git a/src/rgw/rgw_user.cc b/src/rgw/rgw_user.cc
index a4c56dc76475887d2cdaedbe65ca26296ccbe54e..23575d8a0cb3b41afa56d771bd985f38c1c93546 100644 (file)
--- a/src/rgw/rgw_user.cc
+++ b/src/rgw/rgw_user.cc
@@ -1228,6 +1228,10 @@ int RGWSubUserPool::add(RGWUserAdminOpState& op_state, std::string *err_msg, boo
     return ret;
   }
 
+  if (op_state.get_secret_key().empty()) {
+    op_state.set_gen_access();
+  }
+
   ret = execute_add(op_state, &subprocess_msg, defer_user_update);
   if (ret < 0) {
     set_err_msg(err_msg, "unable to create subuser, " + subprocess_msg);

diff --git a/src/rgw/rgw_user.h b/src/rgw/rgw_user.h
index 3cd08d30c77affbe1870eff1b6c1dac44d6ae9b2..af99ed589399b0456f85ea20022226748d532016 100644 (file)
--- a/src/rgw/rgw_user.h
+++ b/src/rgw/rgw_user.h
@@ -233,7 +233,6 @@ struct RGWUserAdminOpState {
     }
 
     subuser_specified = true;
-    gen_access = true;
   }
   void set_caps(std::string& _caps) {
     if (_caps.empty())