]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw: clean up fixes for extra spaces and indentation.
authorShilpa Jagannath <smanjara@redhat.com>
Fri, 28 Aug 2020 06:00:04 +0000 (11:30 +0530)
committerCasey Bodley <cbodley@redhat.com>
Fri, 5 Feb 2021 02:05:58 +0000 (21:05 -0500)
Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
src/rgw/rgw_admin.cc
src/rgw/rgw_bucket_layout.h
src/rgw/rgw_common.h
src/rgw/rgw_rados.cc
src/rgw/rgw_reshard.cc

index 723c8a81a578022f885427199f99df17f2119c9a..05f4fd47ccd0b0a6cadb3184019918f9f4aa901f 100644 (file)
@@ -6609,7 +6609,7 @@ next:
       do {
         entries.clear();
         ret = store->getRados()->bi_list(bs, object, marker, max_entries, &entries, &is_truncated);
-        if (ret < 0) {            
+        if (ret < 0) {
           cerr << "ERROR: bi_list(): " << cpp_strerror(-ret) << std::endl;
           return -ret;
         }
index 7839c519520469c3440dbe2f96d38f4c61884564..6ba752a2d1686ccec1c5d201fd2251a5cb6877c1 100644 (file)
@@ -66,7 +66,6 @@ void decode(bucket_index_layout& l, bufferlist::const_iterator& bl);
 struct bucket_index_layout_generation {
   uint64_t gen = 0;
   bucket_index_layout layout;
-
 };
 
 void encode(const bucket_index_layout_generation& l, bufferlist& bl, uint64_t f=0);
index 3631273075de58bd1f814b1df3414b100791eef8..8541abf3e897d6bebc747c5aa3a7d67b9dc0dc9a 100644 (file)
@@ -997,11 +997,6 @@ struct RGWBucketInfo {
   // layout of bucket index objects
   rgw::BucketLayout layout;
 
-  // Represents the number of bucket index object shards:
-  //   - value of 0 indicates there is no sharding (this is by default
-  //     before this feature is implemented).
-  //   - value of UINT32_T::MAX indicates this is a blind bucket.
-
   // Represents the shard number for blind bucket.
   const static uint32_t NUM_SHARDS_BLIND_BUCKET;
 
index 424de7ef8df5de1f9d41ee07d8d5ae160c039ef6..d3b830353185c949d57f0245271a2d1fcb3fa884 100644 (file)
@@ -7742,7 +7742,6 @@ int RGWRados::try_refresh_bucket_info(RGWBucketInfo& info,
                                      .set_mtime(pmtime)
                                      .set_attrs(pattrs)
                                      .set_refresh_version(rv));
-            
 }
 
 int RGWRados::put_bucket_instance_info(RGWBucketInfo& info, bool exclusive,
index 2444e39a45ef5df4c2984adf04afa4993ec14279..2498c685833ac8a3778f6885f08e602a1dff393d 100644 (file)
@@ -588,7 +588,8 @@ int RGWBucketReshard::do_reshard(int num_shards,
          // place the multipart .meta object on the same shard as its head object
          obj.index_hash_source = mp.get_key();
        }
-       int ret = store->getRados()->get_target_shard_id(bucket_info.layout.target_index->layout.normal, obj.get_hash_object(), &target_shard_id);
+       ret = store->getRados()->get_target_shard_id(bucket_info.layout.target_index->layout.normal,
+                                                    obj.get_hash_object(), &target_shard_id);
        if (ret < 0) {
          lderr(store->ctx()) << "ERROR: get_target_shard_id() returned ret=" << ret << dendl;
          return ret;
@@ -1025,37 +1026,37 @@ int RGWReshard::process_single_logshard(int logshard_num, const DoutPrefixProvid
        }
 
        {
-       RGWBucketReshard br(store, bucket_info, attrs, nullptr);
-       ret = br.execute(entry.new_num_shards, max_entries, dpp, false, nullptr,
-                        nullptr, this);
-       if (ret < 0) {
-         ldout(store->ctx(), 0) <<  __func__ <<
-           ": Error during resharding bucket " << entry.bucket_name << ":" <<
-           cpp_strerror(-ret)<< dendl;
-         return ret;
-       }
+    RGWBucketReshard br(store, bucket_info, attrs, nullptr);
+    ret = br.execute(entry.new_num_shards, max_entries, dpp, false, nullptr,
+        nullptr, this);
+    if (ret < 0) {
+      ldout(store->ctx(), 0) <<  __func__ <<
+        ": Error during resharding bucket " << entry.bucket_name << ":" <<
+        cpp_strerror(-ret)<< dendl;
+      return ret;
+    }
 
-       ldout(store->ctx(), 20) << __func__ <<
-         " removing reshard queue entry for bucket " << entry.bucket_name <<
-         dendl;
+    ldout(store->ctx(), 20) << __func__ <<
+      " removing reshard queue entry for bucket " << entry.bucket_name <<
+      dendl;
 
-       ret = remove(entry);
-       if (ret < 0) {
-         ldout(cct, 0) << __func__ << ": Error removing bucket " <<
-           entry.bucket_name << " from resharding queue: " <<
-           cpp_strerror(-ret) << dendl;
-         return ret;
-         }
+    ret = remove(entry);
+    if (ret < 0) {
+      ldout(cct, 0) << __func__ << ": Error removing bucket " <<
+        entry.bucket_name << " from resharding queue: " <<
+        cpp_strerror(-ret) << dendl;
+      return ret;
+      }
        }
 
     finished_entry:
 
       Clock::time_point now = Clock::now();
       if (logshard_lock.should_renew(now)) {
-       ret = logshard_lock.renew(now);
-       if (ret < 0) {
-         return ret;
-       }
+             ret = logshard_lock.renew(now);
+             if (ret < 0) {
+               return ret;
+             }
       }
 
       entry.get_key(&marker);