osd: drop osd_debug_drop_op_probability

This is unused and not terribly useful.

Signed-off-by: Sage Weil <sage@redhat.com>

diff --git a/src/common/config_opts.h b/src/common/config_opts.h
index 76c3f0ddd1607f1ba4cea0ebce4f0346311d1764..66e4dc324df3c7f5e79d243f87f5b429fd1070b8 100644 (file)
--- a/src/common/config_opts.h
+++ b/src/common/config_opts.h
@@ -847,7 +847,6 @@ OPTION(osd_recovery_aggressive_backoff, OPT_BOOL, false) // issue aggressive cli
 OPTION(osd_debug_crash_on_ignored_backoff, OPT_BOOL, false) // crash osd if client ignores a backoff; useful for debugging
 OPTION(osd_debug_drop_ping_probability, OPT_DOUBLE, 0)
 OPTION(osd_debug_drop_ping_duration, OPT_INT, 0)
-OPTION(osd_debug_drop_op_probability, OPT_DOUBLE, 0)   // probability of stalling/dropping a client op
 OPTION(osd_debug_op_order, OPT_BOOL, false)
 OPTION(osd_debug_verify_missing_on_start, OPT_BOOL, false)
 OPTION(osd_debug_scrub_chance_rewrite_digest, OPT_U64, 0)

diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc
index ba9352fef16c8907db345884317da44579190c71..9078808e0d55d8b454009f5c0db349f4972989ef 100644 (file)
--- a/src/osd/OSD.cc
+++ b/src/osd/OSD.cc
@@ -8781,14 +8781,6 @@ void OSD::handle_op(OpRequestRef& op, OSDMapRef& osdmap)
     client_session->put();
   }
 
-  if (cct->_conf->osd_debug_drop_op_probability > 0 &&
-      !m->get_source().is_mds()) {
-    if ((double)rand() / (double)RAND_MAX < cct->_conf->osd_debug_drop_op_probability) {
-      dout(0) << "handle_op DEBUG artificially dropping op " << *m << dendl;
-      return;
-    }
-  }
-
   // calc actual pgid
   pg_t _pgid = m->get_raw_pg();
   int64_t pool = _pgid.pool();