]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
Fix issue where ceph_test_rados_io_sequence could select a chunksize of 0 which is... 64121/head
authorJon <jonathan.bailey1@ibm.com>
Mon, 23 Jun 2025 16:18:25 +0000 (17:18 +0100)
committerJon <jonathan.bailey1@ibm.com>
Mon, 23 Jun 2025 16:18:25 +0000 (17:18 +0100)
Fixes an off by one error where we were selecting a chunk size from the range of 0-(X-1) inclusive instead of from a range of 0-X inclusive

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
src/test/osd/ceph_test_rados_io_sequence/ceph_test_rados_io_sequence.cc

index 396ec815afaff5dee6274346866c18a5f1f50a83..1149fab4ec4d33780409eee3dbaff05e3013e988 100644 (file)
@@ -537,19 +537,19 @@ ceph::io_sequence::tester::SelectErasureChunkSize::generate_selections() {
   if (4096 % minimum_chunksize == 0) {
     choices.push_back(4096);
   } else {
-    choices.push_back(minimum_chunksize * rng(4));
+    choices.push_back(minimum_chunksize * (rng(4) + 1));
   }
 
   if ((64 * 1024) % minimum_chunksize == 0) {
     choices.push_back(64 * 1024);
   } else {
-    choices.push_back(minimum_chunksize * rng(64));
+    choices.push_back(minimum_chunksize * (rng(64) + 1));
   }
 
   if ((256 * 1024) % minimum_chunksize == 0) {
     choices.push_back(256 * 1024);
   } else {
-    choices.push_back(minimum_chunksize * rng(256));
+    choices.push_back(minimum_chunksize * (rng(256) + 1));
   }
 
   return choices;