]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mds: remove max_mds config option 10997/head
authorPatrick Donnelly <pdonnell@redhat.com>
Mon, 29 Aug 2016 20:25:10 +0000 (16:25 -0400)
committerPatrick Donnelly <pdonnell@redhat.com>
Mon, 10 Oct 2016 14:07:55 +0000 (10:07 -0400)
It is now required that all changes to max_mds use the run-time `ceph fs
set max_mds` command. The rationale for this change is that it is
confusing to have a configuration for max_mds which is only observed at
file system creation.

Fixes: http://tracker.ceph.com/issues/17105
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 52f4e545e0ce4782d5f2239d31080d392c12eba2)

doc/cephfs/mds-config-ref.rst
src/common/config_opts.h
src/mon/MDSMonitor.cc

index a57e67ea10ed906772e37f7b0e48874a74cd5bb2..60f17450ac4cb2955491dfa8bc11e174ea9e89d3 100644 (file)
 :Default: ``true`` 
 
 
-``max mds``
-
-:Description: The number of active MDS daemons during cluster creation. Set
-              under ``[mon]`` or ``[global]``.
-              
-:Type:  32-bit Integer
-:Default: ``1``
-
-
 ``mds max file size``
 
 :Description: The maximum allowed file size to set when creating a 
index 7be42312fd781fe5f2026da450befb642444b415..bf155d9bef0bd742b9cba9d6841d5f3eb42471ba 100644 (file)
@@ -524,7 +524,6 @@ OPTION(mds_inject_traceless_reply_probability, OPT_DOUBLE, 0) /* percentage
 OPTION(mds_wipe_sessions, OPT_BOOL, 0)
 OPTION(mds_wipe_ino_prealloc, OPT_BOOL, 0)
 OPTION(mds_skip_ino, OPT_INT, 0)
-OPTION(max_mds, OPT_INT, 1)
 OPTION(mds_standby_for_name, OPT_STR, "")
 OPTION(mds_standby_for_rank, OPT_INT, -1)
 OPTION(mds_standby_for_fscid, OPT_INT, -1)
index 6d6fb9d52d336c010e6b89ac66f49ba93960f8ce..5ce4b09575467a76bab60fe7d07c4735d65f787f 100644 (file)
@@ -92,7 +92,7 @@ void MDSMonitor::create_new_fs(FSMap &fsm, const std::string &name,
 {
   auto fs = std::make_shared<Filesystem>();
   fs->mds_map.fs_name = name;
-  fs->mds_map.max_mds = g_conf->max_mds;
+  fs->mds_map.max_mds = 1;
   fs->mds_map.data_pools.insert(data_pool);
   fs->mds_map.metadata_pool = metadata_pool;
   fs->mds_map.cas_pool = -1;
@@ -1682,7 +1682,7 @@ int MDSMonitor::management_command(
     // Carry forward what makes sense
     new_fs->fscid = fs->fscid;
     new_fs->mds_map.inline_data_enabled = fs->mds_map.inline_data_enabled;
-    new_fs->mds_map.max_mds = g_conf->max_mds;
+    new_fs->mds_map.max_mds = 1;
     new_fs->mds_map.data_pools = fs->mds_map.data_pools;
     new_fs->mds_map.metadata_pool = fs->mds_map.metadata_pool;
     new_fs->mds_map.cas_pool = fs->mds_map.cas_pool;