Fix broken logic in running_jobs_for_run()

Signed-off-by: Zack Cerza <zack.cerza@inktank.com>

diff --git a/teuthology/report.py b/teuthology/report.py
index d9a83efd61684e8566e1e19215a6757e7d040419..9d53050d03ee6dace0582e1fc1948f1dfaa23255 100644 (file)
--- a/teuthology/report.py
+++ b/teuthology/report.py
@@ -123,9 +123,9 @@ class ResultsSerializer(object):
         :returns:        A dict like: {'1': '/path/to/1', '2': 'path/to/2'}
         """
         jobs = self.jobs_for_run(run_name)
-        for name in jobs.keys():
-            if not os.path.exists(os.path.join(jobs[name], 'summary.yaml')):
-                jobs.pop(name)
+        for job_id in jobs.keys():
+            if os.path.exists(os.path.join(jobs[job_id], 'summary.yaml')):
+                jobs.pop(job_id)
         return jobs
 
     @property

diff --git a/teuthology/test/test_report.py b/teuthology/test/test_report.py
index 804254da43ecfb1ce286d76d0096dd2bbb8aad86..851caebeed02cf446c2f8d186048e8d9050df066 100644 (file)
--- a/teuthology/test/test_report.py
+++ b/teuthology/test/test_report.py
@@ -54,7 +54,7 @@ class TestSerializer(object):
                                      num_hung=num_hung)
 
         got_jobs = self.reporter.serializer.running_jobs_for_run(run_name)
-        assert len(got_jobs) == job_count - num_hung
+        assert len(got_jobs) == num_hung
 
     def test_json_for_job(self):
         run_name = "test_json_for_job"