Revert: "crimson/osd/ops_executer: prevent access to null pointers caused by gcc...

This reverts commit b5665cfac472edefbf45a16f726663c6709a68a9.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

diff --git a/src/crimson/osd/ops_executer.cc b/src/crimson/osd/ops_executer.cc
index 32b2cbcb940f45794ac3ffdd7ba23dac0f740298..991c16d7aaea8037e4c1cd255ed68b8993b3a37a 100644 (file)
--- a/src/crimson/osd/ops_executer.cc
+++ b/src/crimson/osd/ops_executer.cc
@@ -867,19 +867,9 @@ OpsExecuter::flush_changes_and_submit(
     if (auto log_rit = log_entries.rbegin(); log_rit != log_entries.rend()) {
       ceph_assert(log_rit->version == osd_op_params->at_version);
     }
-
-    /*
-     * This works around the gcc bug causing the generated code to incorrectly
-     * execute unconditionally before the predicate.
-     *
-     * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101244
-     */
-    auto clone_obc = cloning_ctx
-      ? std::move(cloning_ctx->clone_obc)
-      : nullptr;
     auto [_submitted, _all_completed] = co_await pg->submit_transaction(
       std::move(obc),
-      std::move(clone_obc),
+      cloning_ctx ? std::move(cloning_ctx->clone_obc) : nullptr,
       std::move(txn),
       std::move(*osd_op_params),
       std::move(log_entries)