]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/cephadm: f-string is missing placeholders (F541)
authorMichael Fritch <mfritch@suse.com>
Thu, 28 Jan 2021 19:43:10 +0000 (12:43 -0700)
committerSebastian Wagner <sebastian.wagner@suse.com>
Tue, 23 Feb 2021 09:58:23 +0000 (10:58 +0100)
Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 22d6a1b7d8ce5530ef67f2ea8b1a9f9681dedf3a)

src/pybind/mgr/cephadm/module.py
src/pybind/mgr/cephadm/serve.py
src/pybind/mgr/tox.ini

index 8d4d86b89bece8a55caa644a5c3882c318166b3a..9125905a675bfebdd1eb885cfe7b6e925c4967ad 100644 (file)
@@ -524,7 +524,7 @@ class CephadmOrchestrator(orchestrator.Orchestrator, MgrModule,
                 # if _ANY_ osd that is currently in the queue appears to be empty,
                 # start the removal process
                 if int(osd.get('osd')) in self.to_remove_osds.as_osd_ids():
-                    self.log.debug(f"Found empty osd. Starting removal process")
+                    self.log.debug('Found empty osd. Starting removal process')
                     # if the osd that is now empty is also part of the removal queue
                     # start the process
                     self._kick_serve_loop()
@@ -1341,7 +1341,7 @@ class CephadmOrchestrator(orchestrator.Orchestrator, MgrModule,
         :raises OrchestratorError: Hostname is invalid, host is already in maintenance
         """
         if len(self.cache.get_hosts()) == 1:
-            raise OrchestratorError(f"Maintenance feature is not supported on single node clusters")
+            raise OrchestratorError("Maintenance feature is not supported on single node clusters")
 
         # if upgrade is active, deny
         if self.upgrade.upgrade_state:
index 13ae1fec1f1bebce88f83f17ca2373c91fe2a73c..a592397c48ed8c5c836c4bb5803031bad477486f 100644 (file)
@@ -329,7 +329,7 @@ class CephadmServe:
         # query OSDSpecs for host <search host> and generate/get the preview
         # There can be multiple previews for one host due to multiple OSDSpecs.
         previews.extend(self.mgr.osd_service.get_previews(search_host))
-        self.log.debug(f"Loading OSDSpec previews to HostCache")
+        self.log.debug(f'Loading OSDSpec previews to HostCache for host <{search_host}>')
         self.mgr.cache.osdspec_previews[search_host] = previews
         # Unset global 'pending' flag for host
         self.mgr.cache.loading_osdspec_preview.remove(search_host)
index dd66314258c9ffc1015f5b01d7d50698b939a77f..972f8e82ecbeb3417dab5e301526c108a56dea76 100644 (file)
@@ -13,7 +13,6 @@ max-line-length = 100
 ignore =
     E501,
     F401,
-    F541,
     F632,
     F811,
     F821,