cmake: use "" for no-op INSTALL_COMMAND

as suggested by CMake document, see
https://cmake.org/cmake/help/latest/module/ExternalProject.html

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/cmake/modules/BuildDPDK.cmake b/cmake/modules/BuildDPDK.cmake
index b33bda0a9b6fe7076566a5983cfa70e90f2b2ecd..69aa471c3744183a9a2a528e25ce2ed343b290e5 100644 (file)
--- a/cmake/modules/BuildDPDK.cmake
+++ b/cmake/modules/BuildDPDK.cmake
@@ -88,7 +88,7 @@ function(do_build_dpdk dpdk_dir)
     CONFIGURE_COMMAND ${make_cmd} config O=${dpdk_dir} T=${target}
     BUILD_COMMAND ${make_cmd} O=${dpdk_dir} CC=${CMAKE_C_COMPILER} EXTRA_CFLAGS=-fPIC
     BUILD_IN_SOURCE 1
-    INSTALL_COMMAND "true")
+    INSTALL_COMMAND "")
   if(NUMA_FOUND)
     set(numa "y")
   else()

diff --git a/cmake/modules/BuildRocksDB.cmake b/cmake/modules/BuildRocksDB.cmake
index 5ab2e8e49d8abd60cd79cea62a2977af413cb563..5ae164424793fccee785be67fccc598cd8a48ec0 100644 (file)
--- a/cmake/modules/BuildRocksDB.cmake
+++ b/cmake/modules/BuildRocksDB.cmake
@@ -82,7 +82,7 @@ function(build_rocksdb)
     BINARY_DIR "${rocksdb_BINARY_DIR}"
     BUILD_COMMAND "${make_cmd}"
     BUILD_BYPRODUCTS "${rocksdb_LIBRARY}"
-    INSTALL_COMMAND "true"
+    INSTALL_COMMAND ""
     LIST_SEPARATOR !)
 
   add_library(RocksDB::RocksDB STATIC IMPORTED)

diff --git a/cmake/modules/BuildSPDK.cmake b/cmake/modules/BuildSPDK.cmake
index 17b2d74cd19960684d4d2f2ea53d7c577b7f8b36..c5351956c69575322afa2485e0094371b13271fb 100644 (file)
--- a/cmake/modules/BuildSPDK.cmake
+++ b/cmake/modules/BuildSPDK.cmake
@@ -52,7 +52,7 @@ macro(build_spdk)
     BUILD_COMMAND env -i PATH=$ENV{PATH} CC=${CMAKE_C_COMPILER} ${make_cmd} EXTRA_CFLAGS="${spdk_CFLAGS}"
     BUILD_IN_SOURCE 1
     BUILD_BYPRODUCTS ${spdk_libs}
-    INSTALL_COMMAND "true")
+    INSTALL_COMMAND "")
   unset(make_cmd)
   foreach(spdk_lib ${SPDK_LIBRARIES})
     add_dependencies(${spdk_lib} spdk-ext)

diff --git a/cmake/modules/Buildpmem.cmake b/cmake/modules/Buildpmem.cmake
index 2439ac0fd2d3f90121caedbf0af73f68f6e0e018..fc17baeaa821b19fe169d48536272652fea4aced 100644 (file)
--- a/cmake/modules/Buildpmem.cmake
+++ b/cmake/modules/Buildpmem.cmake
@@ -27,7 +27,7 @@ function(build_pmem)
       BUILD_COMMAND ${make_cmd} CC=${CMAKE_C_COMPILER} NDCTL_ENABLE=n
       BUILD_IN_SOURCE 1
       BUILD_BYPRODUCTS "${PMDK_LIB}/libpmem.a" "${PMDK_LIB}/libpmemobj.a"
-      INSTALL_COMMAND "true")
+      INSTALL_COMMAND "")
 
   # libpmem
   add_library(pmem::pmem STATIC IMPORTED)

diff --git a/src/compressor/zstd/CMakeLists.txt b/src/compressor/zstd/CMakeLists.txt
index b53b0d9444824ee13beb8f0444c18b16a4250038..1138f6207ddc2dac73effac216e683b89d921602 100644 (file)
--- a/src/compressor/zstd/CMakeLists.txt
+++ b/src/compressor/zstd/CMakeLists.txt
@@ -15,7 +15,7 @@ ExternalProject_Add(zstd_ext
   BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/libzstd
   BUILD_COMMAND ${CMAKE_COMMAND} --build <BINARY_DIR> --target libzstd_static
   BUILD_BYPRODUCTS "${CMAKE_CURRENT_BINARY_DIR}/libzstd/lib/libzstd.a"
-  INSTALL_COMMAND "true")
+  INSTALL_COMMAND "")
 
 add_library(zstd STATIC IMPORTED)
 set_target_properties(zstd PROPERTIES