]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mon/MDSMonitor: add note about missing metadata inclusion
authorPatrick Donnelly <pdonnell@redhat.com>
Fri, 3 May 2024 00:49:22 +0000 (20:49 -0400)
committerPatrick Donnelly <pdonnell@redhat.com>
Thu, 9 May 2024 12:25:29 +0000 (08:25 -0400)
There is a "client_count" metadata on the health warning that apparently was
intended to be used for aggregating warnings but never was. Add a TODO item for
that.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 6517b704e311fd24dbf5bfbdec2ddd23b17d4092)

src/mon/MDSMonitor.cc

index 0ac5060f79c54816254638fe96c32060b967b85e..88894d73fc887dd5728d2fb978465ec87d3ff79e 100644 (file)
@@ -275,6 +275,7 @@ void MDSMonitor::encode_pending(MonitorDBStore::TransactionRef t)
   }
   pending.get_health_checks(&new_checks);
   for (auto& p : new_checks.checks) {
+    // TODO: handle "client_count" metadata when summarizing
     p.second.summary = std::regex_replace(
       p.second.summary,
       std::regex("%num%"),