]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
osd: disable potentially dangerous dead code
authorSage Weil <sage@newdream.net>
Thu, 19 Aug 2010 23:06:24 +0000 (16:06 -0700)
committerGreg Farnum <gregf@hq.newdream.net>
Thu, 19 Aug 2010 23:49:39 +0000 (16:49 -0700)
Greg got a segfault accessing the OSDOP& first reference. Not clear why,
but this whole block is dead code.

src/osd/ReplicatedPG.cc

index 4fc1801735c017ca0decab75c16c266caf391437..9baa8685cbbaef7feec4696892f828f65062f01f 100644 (file)
@@ -2139,13 +2139,13 @@ void ReplicatedPG::op_applied(RepGather *repop)
 
   update_stats();
 
+#if 0
   // any completion stuff to do here?
   if (repop->ctx->ops.size()) {
     const sobject_t& soid = repop->ctx->obs->oi.soid;
     OSDOp& first = repop->ctx->ops[0];
 
     switch (first.op.op) { 
-#if 0
     case CEPH_OSD_OP_UNBALANCEREADS:
       dout(-10) << "op_applied  completed unbalance-reads on " << oid << dendl;
       unbalancing_reads.erase(oid);
@@ -2164,7 +2164,6 @@ void ReplicatedPG::op_applied(RepGather *repop)
        }
       */
       break;
-#endif
 
     case CEPH_OSD_OP_WRUNLOCK:
       dout(-10) << "op_applied  completed wrunlock on " << soid << dendl;
@@ -2175,6 +2174,7 @@ void ReplicatedPG::op_applied(RepGather *repop)
       break;
     }   
   }
+#endif
 
   if (!repop->aborted)
     eval_repop(repop);