qa/tox.ini: check for dead symlinks

IMO the amount of symlinks we have to manually maintain
is tedious and error prone. Any ideas on improving thing?

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

diff --git a/qa/CMakeLists.txt b/qa/CMakeLists.txt
index 884c41e4bbafe376ccc7d952901749440aba72ca..b8d4872ac0e152786f1cc81115da092da3fbd791 100644 (file)
--- a/qa/CMakeLists.txt
+++ b/qa/CMakeLists.txt
@@ -5,5 +5,5 @@ endif()
 
 if(WITH_TESTS)
   include(AddCephTest)
-  add_tox_test(qa TOX_ENVS py3 flake8 mypy)
+  add_tox_test(qa TOX_ENVS py3 flake8 mypy deadsymlinks)
 endif()

diff --git a/qa/suites/rgw-multisite-upgrade/.qa b/qa/suites/rgw-multisite-upgrade/.qa
new file mode 120000 (symlink)
index 0000000..fea2489
--- /dev/null
+++ b/qa/suites/rgw-multisite-upgrade/.qa
@@ -0,0 +1 @@
+../.qa
\ No newline at end of file

diff --git a/qa/tox.ini b/qa/tox.ini
index 1046597ac1661f1b18a3cb38bad594f522b19ae7..6d5ae7ecba6b194d9c753b217ce06f931e173dd8 100644 (file)
--- a/qa/tox.ini
+++ b/qa/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = flake8, mypy, pytest
+envlist = flake8, mypy, pytest, deadsymlinks
 skipsdist = True
 
 [testenv:flake8]
@@ -31,3 +31,10 @@ commands =
   pytest --assert=plain test_import.py
   pytest tasks/tests
 
+[testenv:deadsymlinks]
+basepython = python3
+toxworkdir = {toxinidir}
+allowlist_externals = 
+  bash
+commands =
+  bash -c '! (find . -xtype l | grep ^)'