OSD: big parameter passed by value, send_still_alive

CID 717050: Big parameter passed by value (PASS_BY_VALUE)At (1): Passing
parameter i of type entity_inst_t (size 152 bytes) by value.

Signed-off-by: Samuel Just <sam.just@inktank.com>

diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc
index 42fb43d542148e3b7cd9e855785b8cb13eff41e6..19d2010d3fd425bbb3f1032740566aaf70557454 100644 (file)
--- a/src/osd/OSD.cc
+++ b/src/osd/OSD.cc
@@ -2484,7 +2484,7 @@ void OSD::send_failures()
   if (locked) heartbeat_lock.Unlock();
 }
 
-void OSD::send_still_alive(epoch_t epoch, entity_inst_t i)
+void OSD::send_still_alive(epoch_t epoch, const entity_inst_t &i)
 {
   MOSDFailure *m = new MOSDFailure(monc->get_fsid(), i, 0, epoch);
   m->is_failed = false;

diff --git a/src/osd/OSD.h b/src/osd/OSD.h
index 2fb4b2ce225285a901579a00b28bb3c2575b330a..dc8b8daad706c47b47ea77d07c67fad8d57a77ae 100644 (file)
--- a/src/osd/OSD.h
+++ b/src/osd/OSD.h
@@ -832,7 +832,7 @@ protected:
 
 
   void send_failures();
-  void send_still_alive(epoch_t epoch, entity_inst_t i);
+  void send_still_alive(epoch_t epoch, const entity_inst_t &i);
 
   // -- pg stats --
   Mutex pg_stat_queue_lock;